Uploaded image for project: 'Jalview'
  1. Jalview
  2. JAL-3068

Tidy up Text/Lineart option dialog duplication

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.11.1_js, 2.11.2.0
    • Component/s: jvdesktop
    • Labels:
      None

      Description

      Dialogs EPSOptions, HTMLOptions, SVGOptions are pretty much duplicates apart from two parameters:
      - preferences key (EPS_RENDERING / HTML_RENDERING / SVG_RENDERING)
      - message bundle parameter (EPS/HTML/SVG) for dialog title and label
      and could easily be reduced to one class.
      This may slightly simplify the JalviewJS refactoring of dialog chaining involving this dialog (JAL-3048).
      Also:
      - dialog title, and radio button label for HTML and SVG, are not i18n
      - Preferences Output option is only for EPS - need options for HTML and SVG as well
      - as it is, restoring 'Prompt each time' requires the user to know to delete the preference entry

        Attachments

          Issue Links

          related with

          Task - A task that needs to be done. JAL-3048 Refactor all dialogs to chained runnable pattern

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. JAL-3169 Change 'Overwrite file?' dialog to standard pattern

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

            Activity

              People

              Assignee:
              gmungoc Mungo Carstairs
              Reporter:
              gmungoc Mungo Carstairs
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: