Uploaded image for project: 'Jalview'
  1. Jalview
  2. JAL-3048

Refactor all dialogs to chained runnable pattern

    XMLWordPrintable

    Details

    • Type: Task
    • Status: In Progress
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 2.11.1_js
    • Component/s: jalview-j2s, jvdesktop
    • Labels:
      None

      Description

      Blocking dialogs that control subsequent code execution (e.g. file-chooser->load file) need to be refactored for java2script. To avoid breaking java2script functionality, all dialogs should be refactored to adopt the same pattern:

      dialog = new JvDialog(...)
      configure
      dialog.setRunnable({ code that runs to decide what to do with response })

        Attachments

          Issue Links

          related with

          Bug - A problem which impairs or prevents the functions of the product. JAL-3809 Edit web service parameters dialog does not work in jalviewjs

          • Major - Major loss of function.
          • Being tested

          Task - A task that needs to be done. JAL-3058 Refactor colour chooser dialogs for JS compatibility

          • Major - Major loss of function.
          • In Progress

          Task - A task that needs to be done. JAL-3068 Tidy up Text/Lineart option dialog duplication

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • In Progress

          Task - A task that needs to be done. JAL-3060 Make Feature Editor a top level class

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Ready for testing

          Improvement - An improvement or enhancement to an existing feature or task. JAL-3169 Change 'Overwrite file?' dialog to standard pattern

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

            Activity

              People

              Assignee:
              gmungoc Mungo Carstairs
              Reporter:
              jprocter Jim Procter
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: