Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.11.3.0
-
Fix Version/s: 2.11.3.1
-
Component/s: chimerax, Structures
-
Labels:None
-
Urgency:Not urgent
Description
The method StructureManager.getChimeraPaths(boolean isX), which finds likely installations of Chimera or ChimeraX relies on a list of version numbers known to work.
This is both historical and kept because ChimeraX 1.1 was known not to work with Jalview due to a recognised bug in ChimeraX 1.1's API implementation (that's in ChimeraX, not in Jalview).
This seems wrong to me for two reasons:
1) I don't think the onus should be on Jalview to work around bugs that are unlikely to happen, and where do we draw the line (e.g. if the API works in a particular version but the colouring doesn't in certain circumstances, do we exclude that version?);
2) the list of versions has to be maintained, which can't happen between Jalview releases.
The method should be changed to look for the most recent version installed that isn't in a blacklist of versions (which would contain "1.1").
This is both historical and kept because ChimeraX 1.1 was known not to work with Jalview due to a recognised bug in ChimeraX 1.1's API implementation (that's in ChimeraX, not in Jalview).
This seems wrong to me for two reasons:
1) I don't think the onus should be on Jalview to work around bugs that are unlikely to happen, and where do we draw the line (e.g. if the API works in a particular version but the colouring doesn't in certain circumstances, do we exclude that version?);
2) the list of versions has to be maintained, which can't happen between Jalview releases.
The method should be changed to look for the most recent version installed that isn't in a blacklist of versions (which would contain "1.1").
