Details
-
Type:
Task
-
Status: Open
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: 2.11.1
-
Fix Version/s: 2.11.2
-
Component/s: Dev and Dep, getdown
-
Labels:
-
Urgency:Not urgent
Description
In the source tree, all getdown related items are filed away under the top level "getdown" folder. This contains
getdown/lib
getdown/src
getdown/files
getdown/website
These should be moved to locations more appropriate for gradle:
getdown/lib -> utils/getdown/lib
getdown/src -> src/getdown
getdown/files -> build/getdown/files
getdown/website -> build/getdown/website
Note that src/getdown should not be compiled with the usual Jalview compile so should be excluded from both the eclipse and gradle compilers.
The compilation currently uses maven and needs a JDK 1.8 so is compiled separately (and much less frequently) with the resulting jars being copied to getdown/lib and j8lib and j11lib. (see getdown/src/getdown/mvn_cmd)
The getdown/files and getdown/website folders are actually target build folders and should be empty in the repo. These should properly be deleted and gradle will create them automatically in build/getdown/... . Under build/ they will also be deleted with gradle clean.
Theses changes can be made very easily but should probably be done just after the 2.11.1 release when branches (in particular involving getdown) are more stable. The movement of dirs should not affect other branches, but it might confuse them (hopefully `git mv` will avoid confusion though).
getdown/lib
getdown/src
getdown/files
getdown/website
These should be moved to locations more appropriate for gradle:
getdown/lib -> utils/getdown/lib
getdown/src -> src/getdown
getdown/files -> build/getdown/files
getdown/website -> build/getdown/website
Note that src/getdown should not be compiled with the usual Jalview compile so should be excluded from both the eclipse and gradle compilers.
The compilation currently uses maven and needs a JDK 1.8 so is compiled separately (and much less frequently) with the resulting jars being copied to getdown/lib and j8lib and j11lib. (see getdown/src/getdown/mvn_cmd)
The getdown/files and getdown/website folders are actually target build folders and should be empty in the repo. These should properly be deleted and gradle will create them automatically in build/getdown/... . Under build/ they will also be deleted with gradle clean.
Theses changes can be made very easily but should probably be done just after the 2.11.1 release when branches (in particular involving getdown) are more stable. The movement of dirs should not affect other branches, but it might confuse them (hopefully `git mv` will avoid confusion though).