Details
-
Type:
Task
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.11.0, 2.11.1_js
-
Fix Version/s: None
-
Component/s: Dev and Dep, jalview-j2s
-
Labels:None
Description
json_simple-1.1.jar (org.json.simple) is a library used by Jalview in
jalview.util.Platform
jalview.util.JSONUtils
jalview.ext.ensembl.Ensembl*
There is a jar for this in j8libs and j11libs
There are also source (.java) files for json-simple (1.1) and other org.json.* classes in src/org/json/... .
Java (desktop) tests work the same with or without the source version.
Java (desktop) compilation using JDK 11 flags up deprecated methods:
src/org/json/simple/JSONValue.java:44: public static Object parse(Reader in)
src/org/json/simple/JSONValue.java:74: public static Object parse(String s)
These specific warnings could be removed by adding @Deprecated annotations to the two methods (done!).
json-simple 1.x is now deprecated as a whole (last version 1.1.1 2012) and may not work with Java 11+ onwards so there should be consideration for replacing it with a newer version (either/both source or jar library).
If we are using a modified version in the source tree then there are maintenance implications.
Continuation to use this version of json-simple seems okay at the moment but a switch to a more recent JSON parsing library might be needed for future compilers. Implications for Jalview-JS build might be that no adaptations are needed (or might mean more adaptations are needed)!
Notes:
json-simple-1.1.1 (2012) is the last version of this json-simple library.
There is a current (3.1.0 2019) library of the same name json-simple
https://cliftonlabs.github.io/json-simple/
but I am not sure that this is a continuation of the 1.1.1 version. It is packaged as com.github.cliftonlabs.json_simple.
jalview.util.Platform
jalview.util.JSONUtils
jalview.ext.ensembl.Ensembl*
There is a jar for this in j8libs and j11libs
There are also source (.java) files for json-simple (1.1) and other org.json.* classes in src/org/json/... .
Java (desktop) tests work the same with or without the source version.
Java (desktop) compilation using JDK 11 flags up deprecated methods:
src/org/json/simple/JSONValue.java:44: public static Object parse(Reader in)
src/org/json/simple/JSONValue.java:74: public static Object parse(String s)
These specific warnings could be removed by adding @Deprecated annotations to the two methods (done!).
json-simple 1.x is now deprecated as a whole (last version 1.1.1 2012) and may not work with Java 11+ onwards so there should be consideration for replacing it with a newer version (either/both source or jar library).
If we are using a modified version in the source tree then there are maintenance implications.
Continuation to use this version of json-simple seems okay at the moment but a switch to a more recent JSON parsing library might be needed for future compilers. Implications for Jalview-JS build might be that no adaptations are needed (or might mean more adaptations are needed)!
Notes:
json-simple-1.1.1 (2012) is the last version of this json-simple library.
There is a current (3.1.0 2019) library of the same name json-simple
https://cliftonlabs.github.io/json-simple/
but I am not sure that this is a continuation of the 1.1.1 version. It is packaged as com.github.cliftonlabs.json_simple.