Uploaded image for project: 'Jalview'
  1. Jalview
  2. JAL-3452

SequenceFeature.isNonPositional not a valid check

    XMLWordPrintable

    Details

      Description

      The method

        public boolean isNonPositional()
        {
          return begin == 0 && end == 0;
        }

      in SequenceFeature is not sufficient and causes sequence features to be missed and, as a result, causes PDBSequenceFetcherTest to fail.

      In the test for model 4im2, there is a residue with resno 0 -- SER0. PDBChain.makeResidueList attempts to add SER0 to the SequenceFeatureStore, but the store adds it to the nonpositional list rather than to its featureStore, since it has end=0 and start=0.

      It's curious to me why this has not been caught before. Am I the first to run PDBSequenceFetcherTest?

        Attachments

          Activity

            People

            Assignee:
            gmungoc Mungo Carstairs
            Reporter:
            hansonr Bob Hanson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated: