Details
-
Type: Bug
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: 2.10.5
-
Component/s: jalview-j2s, jvdesktop
-
Labels:None
Description
Method AAFrequency.extractProfile() converts residue counts to percentages (rounded down to integer). This can result in zero values (e.g. count 1 out of total 101).
In Java this is harmless: AnnotationRenderer.drawBarGraph() draws the character, shifts offset by its height (zero) and then draws the remaining profile residues over it. Just a bit of unnecessary processing (e.g. find residue colour).
In JalviewJS the font scaling is done differently, there is a divide by zero - resulting in Infinity - and the profile fails to be drawn correctly or at all.
Noticed while testing JalviewJS with a JPred result alignment of 450 sequences. This bug can't show up in an alignment of 100 sequences or less. Or should that be fewer.
In Java this is harmless: AnnotationRenderer.drawBarGraph() draws the character, shifts offset by its height (zero) and then draws the remaining profile residues over it. Just a bit of unnecessary processing (e.g. find residue colour).
In JalviewJS the font scaling is done differently, there is a divide by zero - resulting in Infinity - and the profile fails to be drawn correctly or at all.
Noticed while testing JalviewJS with a JPred result alignment of 450 sequences. This bug can't show up in an alignment of 100 sequences or less. Or should that be fewer.