Uploaded image for project: 'Jalview'
  1. Jalview
  2. JAL-2963

PCA points not dimmed when rotated about y axis

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.10.3
    • Fix Version/s: 2.11.0
    • Component/s: jvdesktop, jvlite
    • Labels:
      None

      Description

      PCA display dims (darkens) points that are behind the plane of the centre (have negative z coordinate). The test is in RotatableCanvas.drawScene:
          float z = sp.coord[1] - centre[2];
          if (z < 0) { /* darken */ }
      looks wrong, should be sp.coord[2] - centre[2].
      Sure enough, if you drag the mouse left and right to rotate around the y axis (y value remains constant), no dimming / undimming is seen, although points are conceptually getting rotated to the back or front.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              gmungoc Mungo Carstairs
              Reporter:
              gmungoc Mungo Carstairs
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: