Uploaded image for project: 'Jalview'
  1. Jalview
  2. JAL-2443

Remove getResidueBoxColour from api.SequenceRenderer

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.10.2
    • Component/s: renderer
    • Labels:
      None

      Description

      Calls to SequenceRenderer.getResidueBoxColour are always followed by a call to findFeatureColour (unless feature display is turned off).

      This logic is already encapsulated in method SequenceRenderer.getResidueColour() so it would be simpler always to use this method instead.

      Remove getResidueBoxColour from the api and change all calls to it to just call getResidueColour. This method now accepts a FeatureColourFinder (JAL-2438) so it can do the feature colour lookup after the colour scheme lookup.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              gmungoc Mungo Carstairs
              Reporter:
              gmungoc Mungo Carstairs
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: