Uploaded image for project: 'Jalview'
  1. Jalview
  2. JAL-2391

Review PDBEntry.Type enum - use FileFormatI instead?

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Blocker
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Structures
    • Labels:
      None

      Description

      JAL-2344 created an enum FileFormat including values for mmCIF and PDB.
      Can these be used in place of enum PDBEntry.Type?
      Need to review:
      1) Type enum includes FILE as a value - unclear how this is used
      2) Type enum fields ext (e.g "cif") and format (e.g. "mmcif") have specific uses (for Chimera Open command, and dbfetch, respectively) - would need to decouple these values from the FileFormat properties
      3) PDBEntry.type is a String which can be set directly or via a Type enum - code design needs to be clearer here e.g.
        - Uniprot.uniprotEntryToSequenceI() tests for "EMBL" or "Ensembl" - are these ever set? if so it suggests a separate property rather than overloading the meaning of PDBEntry.type

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jprocter James Procter
              Reporter:
              gmungoc Mungo Carstairs
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: