Uploaded image for project: 'Jalview'
  1. Jalview
  2. JAL-1781

Use 'true' ids and sequence ref when storing annotation in project

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.8.2
    • Fix Version/s: 2.9
    • Labels:
      None

      Description

      <Annotation> element in project uses AlignmentAnnotation.id (which is hashCode()).
      This is theoretically not unique. A simple reference counter ann0, ann1, ann2,... would be safer.

      Annotation sequenceRef attribute is set to sequence name - not guaranteed unique.
      As per comment in the code at storeAlignmentAnnotation, would be better to use sequence (XML) id.
      This is available in the seqsToIds lookup table.
      Similarly on load, the seqRefIds reverse lookup can provide the sequence.
      If this change is made, project load would need to still handle sequence lookup by name as a fallback, for backwards compatibility.

        Attachments

          Activity

            People

            Assignee:
            gmungoc Mungo Carstairs
            Reporter:
            gmungoc Mungo Carstairs
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: